Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use char * in logging macros #295

Merged
merged 2 commits into from Dec 18, 2020
Merged

Use char * in logging macros #295

merged 2 commits into from Dec 18, 2020

Conversation

audrow
Copy link
Member

@audrow audrow commented Dec 10, 2020

This PR is part of ros2/rclcpp#1442.

@audrow
Pass char * into logging macros rather than std::strings
497503c 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow audrow self-assigned this Dec 10, 2020
@audrow
Fix logging indentation
ab2b47a 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
clalancette
clalancette approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@audrow audrow mentioned this pull request Dec 11, 2020
Merged
@audrow
Copy link
Member Author

audrow commented Dec 18, 2020

Here's CI for ros2/rclcpp#1442, which includes this change:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit 869e303 into master Dec 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the audrow/update-logging branch December 18, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@audrow @clalancette