Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import statement and usage for rclpy.node.Node #189

Merged
merged 1 commit into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented Nov 27, 2017

node is not imported in __init__.py anymore (ros2/rclpy#147)

Without this change the examples raise:
AttributeError: module 'rclpy' has not attribute 'Node'

Not sure if ros2/rclpy#147 is a long term fix as this mean that anyone inheriting from Node will need to import it explicitly.

connects to ros2/demos#196

@mikaelarguedas mikaelarguedas self-assigned this Nov 27, 2017

@mikaelarguedas mikaelarguedas changed the title Import rclpy.node.Node and inherit from Node Fix import statement and usage for rclpy.node.Node Nov 27, 2017

@dhood

dhood approved these changes Nov 27, 2017

@mikaelarguedas mikaelarguedas merged commit 414cefb into master Nov 27, 2017

@mikaelarguedas mikaelarguedas deleted the import_rclpy_node branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.