Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static_cast #21

Merged
merged 1 commit into from
Apr 30, 2015
Merged

Remove static_cast #21

merged 1 commit into from
Apr 30, 2015

Conversation

esteve
Copy link
Member

@esteve esteve commented Apr 29, 2015

@esteve esteve added the in progress Actively being worked on (Kanban column) label Apr 29, 2015
@dirk-thomas
Copy link
Member

This seems to only revert the previous workaround from 53c4255. Why does it work now?

Should we instead "git revert" that commit instead of having a new commit undoing the previous one?

Update: I guess it works after merging ros2/rclcpp#27 ?

@esteve
Copy link
Member Author

esteve commented Apr 29, 2015

@dirk-thomas yes, it'll work after ros2/rclcpp#27 gets merged.

esteve added a commit that referenced this pull request Apr 30, 2015
@esteve
Merge pull request #21 from ros2/callable-compatible
a588308 
Remove static_cast
@esteve esteve merged commit a588308 into master Apr 30, 2015
@esteve esteve removed the in progress Actively being worked on (Kanban column) label Apr 30, 2015
@esteve esteve deleted the callable-compatible branch April 30, 2015 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esteve @dirk-thomas