Fix the MessageFilter init order. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, when using it you get an warning about member order initialization. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
|
All of the test failures in CI also happened in the nightlies, so I think this is good to be reviewed. I'll also propose this as a backport for Dashing patch release 2. |
tfoote
approved these changes
Jun 20, 2019
clalancette
added a commit
that referenced
this pull request
Jul 26, 2019
Otherwise, when using it you get an warning about member order initialization. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when using it you get an warning about
member order initialization.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org