Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing header (for tf2::fromMsg) #126

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Added missing header (for tf2::fromMsg) #126

merged 1 commit into from
Jul 9, 2019

Conversation

esteve
Copy link
Member

@esteve esteve commented Jul 8, 2019

This PR adds tf2_ros/buffer_interface.h to the list of headers so tf2::fromMsg is declared before use.

clalancette
clalancette approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm going to run CI just up to this package, since as far as I can tell nothing else in the ROS 2 core depends directly on it.

@clalancette
Copy link
Contributor

clalancette commented Jul 8, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@esteve
Copy link
Member Author

esteve commented Jul 9, 2019

@clalancette I think the aarch64 job is failing because of an unrelated issue, could you trigger it again? Thanks.

@clalancette
Copy link
Contributor

@clalancette I think the aarch64 job is failing because of an unrelated issue, could you trigger it again? Thanks.

Yeah, that was infrastructure. It actually got re-queued on its own, I just had to update the number. Looking good now, thanks.

@clalancette clalancette merged commit e288af3 into ros2:ros2 Jul 9, 2019
@esteve
Copy link
Member Author

esteve commented Jul 9, 2019

@clalancette thanks!

@esteve esteve deleted the missing-header branch July 9, 2019 16:57
esteve added a commit to esteve/geometry2 that referenced this pull request Aug 7, 2019
@esteve
Added missing header (for tf2::fromMsg) (ros2#126)
08ec796
@esteve esteve mentioned this pull request Aug 7, 2019
Merged
clalancette pushed a commit that referenced this pull request Aug 7, 2019
@esteve @clalancette
Added missing header (for tf2::fromMsg) (#126) (#147)
19e7846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esteve @clalancette