Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style cleanup on tf2_py.cpp #168

Closed
clalancette opened this issue Sep 16, 2019 · 3 comments
Closed

Style cleanup on tf2_py.cpp #168

clalancette opened this issue Sep 16, 2019 · 3 comments
Assignees
@ahcorde
Labels
enhancement New feature or request

Comments

@clalancette
Copy link
Contributor

After #99 is merged, there is a bunch of style cleanup that should be done on https://github.com/ros2/geometry2/blob/ros2/tf2_py/src/tf2_py.cpp . We should do the following:

  1. Switch NULL -> nullptr
  2. Use consistent bracket style everywhere
  3. Enable the cpplint/uncrustify checks from ament to keep the style consistent in the future.
@mabelzhang mabelzhang added the enhancement New feature or request label Sep 19, 2019
@ahcorde ahcorde mentioned this issue Jan 22, 2020
Merged
@ahcorde ahcorde self-assigned this Jan 22, 2020
@ahcorde
Copy link
Contributor

ahcorde commented Jan 22, 2020

PR #222

@ahcorde
Copy link
Contributor

ahcorde commented Feb 18, 2020

excluded ament_copyright and ament_cpplint

I have seen that bsd 3 was included, but I need to make changes (reformat the license) in the header to pass ament_copyright and ament_cpplint

https://github.com/ament/ament_lint/blob/master/ament_copyright/ament_copyright/template/bsd_3clause_header.txt

@clalancette
Copy link
Contributor Author

Fixed by #222 , so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clalancette @ahcorde @mabelzhang