Fix up the dependencies in test_tf2. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
force-pushed
the
clalancette/fix-test-tf2-dependencies
branch
from
16a1484
to
e18e822
Compare
This is to ensure that the tests include what they use, which then makes it easy to figure out which packages each test should ament_target_depend on. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/fix-test-tf2-dependencies
branch
from
e18e822
to
19f7047
Compare
|
ivanpauno
approved these changes
Jun 22, 2020
| @@ -34,15 +33,19 @@ include_directories(${GTEST_INCLUDE_DIRS}) | |||
| ament_add_gtest(buffer_core_test test/buffer_core_test.cpp) | |||
There was a problem hiding this comment.
shouldn't all this be under a if (BUILD_TESTING) condition?
Unrelated to this PR though
There was a problem hiding this comment.
Yeah, that's a good point. It really should be. We have kind of ignored it because we don't build binary packages, but it would be nicer for source users. I'll open an issue about it.
|
|
delete-merged-branch
bot
deleted the
clalancette/fix-test-tf2-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that the tests include what they use,
which then makes it easy to figure out which packages each
test should ament_target_depend on.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix one more bug when building this package in an overlay.