Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reconfiguring qos of tf and tf_static topics through parameters #381

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

ivanpauno
Copy link
Member

Signed-off-by: Ivan Santiago Paunovic ivanpauno@ekumenlabs.com

@ivanpauno ivanpauno added the enhancement New feature or request label Feb 18, 2021
@ivanpauno ivanpauno self-assigned this Feb 18, 2021
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this caused some test failures; seeing "passed non-default qos overriding options without providing a parameters interface".

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/qos-reconfigurability-tf-topics branch from c02e1e9 to 409f042 Compare February 19, 2021 17:01
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

Window failure is unrelated, going in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants