Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import #465

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Remove unused import #465

merged 1 commit into from
Oct 11, 2021

Conversation

nkalupahana
Copy link
Contributor

Removes unused import in view_frames.py that breaks this script on macOS.
If someone could test this on Ubuntu before merging that would be great, thanks :)

@aprotyas
Copy link
Member

aprotyas commented Oct 9, 2021

I recognize that tf2_py is an unused import, but what behavior do you see on macOS? As in, how is it breaking?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to get rid of this unused import, but I have the same question as @aprotyas ; what is failing on macOS?

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 70ca843 into ros2:ros2 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants