Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add doTransform for Wrench messages #476

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Feature: Add doTransform for Wrench messages #476

merged 3 commits into from
Dec 21, 2021

Conversation

destogl
Copy link
Contributor

@destogl destogl commented Nov 15, 2021 •
edited
Loading

Added:

  • methods for transforming and converting Wrenches
  • toMsg method from tf2::Transform to geometry_msgs::msg::Transform (needed in the “backend” for Wrench transformation)

Changed:

  • simplified Vector3Stamped transform-code to reuse Vector3 transform logic (also needed for Wrenches)

This functionality is used in ros2_controllers for Admittance Controller

The code is ported from ros/geometry2#331

@destogl
Copy link
Contributor Author

destogl commented Dec 21, 2021

ping... (?)

clalancette
clalancette approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay here. This looks good to me. I'm going to run CI on it next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 7a66009 into ros2:ros2 Dec 21, 2021
@destogl destogl deleted the destogl/feature/add-wrench-transform branch January 18, 2022 16:41
@clalancette clalancette mentioned this pull request Apr 29, 2022
Closed
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@aprotyas aprotyas aprotyas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@destogl @clalancette @aprotyas