Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2_geometry_msgs: Fixing covariance transformation in doTransform<PoseWithCovarianceStamped, TransformStamped> (backport #430) #488

Merged
merged 1 commit into from Dec 23, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 21, 2021

This is an automatic backport of pull request #430 done by Mergify.
Cherry-pick of ae30f0b has failed:

On branch mergify/bp/galactic/pr-430
Your branch is up to date with 'origin/galactic'.

You are currently cherry-picking commit ae30f0b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tf2_geometry_msgs/test/test_tf2_geometry_msgs.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   tf2_geometry_msgs/include/tf2_geometry_msgs/tf2_geometry_msgs.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…<PoseWithCovarianceStamped, TransformStamped>` (#430)

Fixes #372.

* Implement covariance transformation (cpp).

* Fixed `TfGeometry/FrameWithCovariance` test. The updated test checks against the correctly transformed
covariance matrix.

Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
(cherry picked from commit ae30f0b)
@aprotyas
Copy link
Member

aprotyas commented Dec 21, 2021

Conflicts addressed in a28ae8b.

CI:
Repos file: https://gist.githubusercontent.com/aprotyas/64b0c61ed421237eb4e3f29934e22a62/raw/7d17dc09c9a7589109eb84a032444cf41ff3e15c/ros2.repos
Build args: --packages-up-to tf2_geometry_msgs
Test args: --packages-select tf2_geometry_msgs
Job: https://ci.ros2.org/job/ci_launcher/9541/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: The deprecation warnings during compilation are addressed in ros2/rmw_cyclonedds#359.

@aprotyas
Copy link
Member

aprotyas commented Dec 22, 2021

Re-running CI since ros2/rmw_cyclonedds#359 has landed:

Repos file: https://gist.githubusercontent.com/aprotyas/64b0c61ed421237eb4e3f29934e22a62/raw/7d17dc09c9a7589109eb84a032444cf41ff3e15c/ros2.repos
Build args: --packages-up-to tf2_geometry_msgs
Test args: --packages-select tf2_geometry_msgs
Job: https://ci.ros2.org/job/ci_launcher/9549/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@aprotyas
Copy link
Member

Thanks for the review! I will merge this since there's green CI and an approval.

@aprotyas aprotyas merged commit 5abe0e7 into galactic Dec 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/galactic/pr-430 branch December 23, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants