Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf2_sensor_msgs find the right Python executable. #525

Merged
merged 1 commit into from
May 24, 2022
Merged

tf2_sensor_msgs find the right Python executable. #525

merged 1 commit into from
May 24, 2022

Conversation

Blast545
Copy link
Contributor

This should fix #524

After taking some time to understand the problem, I realized it's the same error that was fixed with #514 and copied the solution provided.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

@Blast545
Make sure to find the right Python executable.
acad537 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545
Copy link
Contributor Author

Windows + debug, up to tf2_sensor_msgs without this PR:
Build Status

Windows + debug, up to tf2_sensor_msgs with this PR:
Build Status

@Blast545 Blast545 self-assigned this May 23, 2022
aprotyas
aprotyas approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@aprotyas aprotyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might make sense to prepend tf2_sensor_msgs to the PR title (or the resulting commit message) to differentiate scope from #514.

@Blast545 Blast545 changed the title Make sure to find the right Python executable. tf2_sensor_msgs find the right Python executable. May 24, 2022
@Blast545
Copy link
Contributor Author

Full CI, --packages-above-and-dependencies tf2_sensor_msgs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Blast545
Copy link
Contributor Author

2 Approvals + full green CI, merging

@Blast545 Blast545 merged commit 85b3d0d into ros2 May 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the blast545/fix_tf2_sensors_msgs_524 branch May 24, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@aprotyas aprotyas aprotyas approved these changes

Assignees

@Blast545 Blast545

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👨‍🌾 tf2_sensor_msgs can't import numpy.core._multiarray_umath on Windows Debug
3 participants
@Blast545 @clalancette @aprotyas