Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action_msgs dependency #547

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remove action_msgs dependency #547

merged 1 commit into from
Aug 23, 2022

Conversation

jacobperron
Copy link
Member

It is now properly included in the rosidl dependency chain.

Also removed an unused dependency on std_msgs.

Depends on ros2/rosidl_defaults#22

It is now properly included in the rosidl dependency chain.

Also removed an unused dependency on std_msgs.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahcorde
Copy link
Contributor

ahcorde commented Aug 18, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron
Copy link
Member Author

CI for all connected PRs was run here: ros2/rosidl_defaults#22 (comment)

@jacobperron jacobperron merged commit b560071 into rolling Aug 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/action_msgs_dep branch August 23, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants