Normalize Quaternions #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pac48
force-pushed
the
pr-normalize-quaternions
branch
from
c562476
to
fa6c84d
Compare
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
pac48
force-pushed
the
pr-normalize-quaternions
branch
from
fa6c84d
to
08409cd
Compare
ahcorde
approved these changes
Jan 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes Eigen Quaternions created from ros messages. Often the Quaternions generated by ROS nodes are not normalized to a high precision, e.g. Quaternions generated from a simulator using 32-bit precision are converted to 64-bit precision and lose their normalization.