Add the ability to assert in stdout or stderr. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
reviewed
Feb 11, 2020
clalancette
force-pushed
the
log_to_stderr
branch
from
30d852e
to
96a7e1d
Compare
clalancette
force-pushed
the
log_to_stderr
branch
from
96a7e1d
to
fb64695
Compare
Since we are switching the underlying logging to be stderr, this is going to be important for tests. This commit refactors assertInStdout() to be assertInStream(), which takes in the stream to be asserted on. It then recreates assertInStdout() on top of that, and adds in assertInStderr(). It also changes assertWaitFor() to wait on the stderr stream by default. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Once we backport this to Eloquent, this will allow users to write tests that work in both Eloquent and newer releases. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
log_to_stderr
branch
from
fb64695
to
e32f82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are switching the underlying logging to be stderr,
this is going to be important for tests. This commit
refactors assertInStdout() to be assertInStream(), which
takes in the stream to be asserted on. It then recreates
assertInStdout() on top of that, and adds in assertInStderr().
It also changes assertWaitFor() to wait on the stderr stream
by default.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This goes along with ros2/rcutils#196