Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unittest.mock instead of mock #487

Merged
merged 1 commit into from Feb 17, 2021
Merged

Use unittest.mock instead of mock #487

merged 1 commit into from Feb 17, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 17, 2021

mock is just a backport of Python 3.3 unittest.mock.

CI up to launch_testing:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Use unittest.mock instead of mock
596acf5 
mock is just a backport of Python 3.3 unittest.mock

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from cottsay February 17, 2021 21:06
@hidmic
Copy link
Contributor Author

hidmic commented Feb 17, 2021

Any job we can run on Fedora @cottsay?

cottsay
cottsay approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any job we can run on Fedora @cottsay?

We don't have any jobs, no.

Thanks for prioritizing this simple fix - it always feels good to shed dependencies.

@hidmic
Copy link
Contributor Author

hidmic commented Feb 17, 2021

Alright, going in.

@hidmic hidmic merged commit 91536a9 into master Feb 17, 2021
@hidmic hidmic deleted the hidmic/use-unittest-mock branch February 17, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @cottsay