to open expected outpout file with an encoding parameter #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2023 07:49
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
iuhilnehc-ynos
changed the title
iuhilnehc-ynos
changed the title
fujitatomoya
approved these changes
Jul 12, 2023
added 2 commits
July 12, 2023 12:48
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
@adityapande-1995 could we have another review? |
…x-file-with-unicode-escape
clalancette
requested changes
Aug 24, 2023
| @@ -64,7 +65,7 @@ def _filter(output): | |||
| return _filter | |||
|
|
|||
|
|
|||
| def expected_output_from_file(path): | |||
| def expected_output_from_file(path, encoding: Optional[str] = None): | |||
There was a problem hiding this comment.
While we are adding in new type annotations, can we add one to path as well?
Suggested change
| def expected_output_from_file(path, encoding: Optional[str] = None): | |
| def expected_output_from_file(path: str, encoding: Optional[str] = None): |
There was a problem hiding this comment.
Yes. Updated in e445d13
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
…x-file-with-unicode-escape
clalancette
approved these changes
Aug 25, 2023
|
CI with repos:
|
…x-file-with-unicode-escape
wjwwood
pushed a commit
that referenced
this pull request
Sep 20, 2023
* add an option to read the regex file by escape mode Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add a test in ros2/rcutils#426, but it does not work if a regex file contains some escape character. (e.g. "\b")