-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional substitution #734
Conversation
Closes: ros2#727 Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic to me, thanks for a nice clean pull request. I'll run CI on it next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlamprian It looks like flake8 is unhappy here, mostly about double quotes but also about some import order stuff. I don't know why the Rpr job didn't pick up on it, but if you setup your workspace locally it should show it to you. That will need to be fixed before we merge this, thanks.
Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
Fixed, allegedly. |
Out of curiosity, what does |
Locally I'm still seeing:
|
Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
The last error is hopefully fixed (the message can be misinterpreted). |
OK, yeah. You are missing a bunch of plugins, and flake8 is a bit annoying in that you can't specify which ones are required; it only runs the plugins you have installed. My list looks like this:
We have a long-term plan to fix this up by making those plugins hard requirements, but we aren't there today. Anyway, this looks good to me now (verified locally), so I'll run CI on this again. Thanks for iterating. |
* Add conditional substitution Closes: #727 Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
@nlamprian is it possible to include this feature also in the Humble branch? |
* Add conditional substitution Closes: ros2#727 Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
Closes #727