-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing parameters as a dictionary #138
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
705b3a6
Pass shallow dicts of parameters
dhood cea143c
Support nested dicts
dhood 2ea0bd1
Support passing parameter lists
dhood 51a9f12
Support non-substitution types in param lists
dhood e67b18c
Error on nested lists
dhood 96319ba
Tests for invalid dicts
dhood dede03d
Invalid param dicts show on execution of nodes
dhood b213a29
Add test checking resulting parameters file
dhood 4430f6d
Test more complex dictionary
dhood 23496bd
Depend on pyyaml
dhood 9e4a292
Don't allow random types to be passed in dict
dhood eb718c3
Docs
dhood 190bd93
Error if node name isn't specified by params dict is given
dhood 9f37427
set() -> {}
dhood e77db1f
Linter fix
dhood cb30484
Add todo for deleting generated files
dhood f243a59
Linter fix
dhood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
'setuptools', | ||
'demo_nodes_py', | ||
'launch_ros', | ||
'pyyaml', | ||
], | ||
zip_safe=True, | ||
author='William Woodall', | ||
|
17 changes: 9 additions & 8 deletions
17
test_launch_ros/test/test_launch_ros/actions/example_parameters.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
talker: | ||
ros__parameters: | ||
some_int: 42 | ||
a_string: "Hello world" | ||
some_list: | ||
sub_list: | ||
some_integers: [1, 2, 3, 4] | ||
some_doubles : [3.14, 2.718] | ||
/my_ns: | ||
my_node: | ||
ros__parameters: | ||
some_int: 42 | ||
a_string: "Hello world" | ||
some_list: | ||
sub_list: | ||
some_integers: [1, 2, 3, 4] | ||
some_doubles : [3.14, 2.718] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention to merge this and follow up with a pull request to clean up the files or do you think we can do without it?
I know we talked about it before and I said it would be ok to not do that for now, but now I'm thinking we should really clean up after ourselves. What are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's important also, was planning to leave it as followup to simplify reviewing of this PR. The tests are relying on the files being around atm so was going to also have an option to disable the cleanup.