Support external ExecuteProcess output overrides. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By means of an $OVERRIDE_LAUNCH_PROCESS_OUTPUT envvar. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added
in progress
dirk-thomas
reviewed
Mar 26, 2019
| on all available options. | ||
| :param: output configuration for process output logging. Defaults to 'log' | ||
| i.e. log both stdout and stderr to launch main log file and stderr to | ||
| the screen. Overridden externally by the $OVERRIDE_LAUNCH_PROCESS_OUTPUT |
There was a problem hiding this comment.
Nitpick: a new sentence should start on a newline. Same below.
Same comment about the $ as in ros2/launch_ros#10 (comment)
There was a problem hiding this comment.
Sure, I tend to add the $ to emphasize it's an envvar. FIxed.
dirk-thomas
approved these changes
Mar 26, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
In the future, please run CI on changes like this, even if they seem trivial. |
|
My bad! Did it fail on |
|
No, just try not to do so, in case it does. If it just touches comments, that's fine, if it touches only docs and you run tests locally that's ok too, but in a case like there where you touch Python code, definitely always run the CI, even if you think the code isn't covered by any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214 by means of an
$OVERRIDE_LAUNCH_PROCESS_OUTPUTenvvar.Lacking a test to keep this PR simple, we can add one if necessary.