Always accept posix paths in LaunchDescriptionSource #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
wjwwood
approved these changes
Jul 9, 2019
|
The three loaders used were actually accepting both kind of paths (python loading machinery, xml loader, yaml loader). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux/Mac,
LaunchDescriptionSourcewill work as before.On Windows:
LaunchDescriptionSourcewill still accept paths in the windows way(e.g.:'path\\to\\file').'path/to/file').It will avoid unnecessary usage of
os.path.joinorpathlib.Pathin many launch files.It will also allow always using posix style in the new launch xml and yaml formats. I can do another workaround for that, but this seems like a better change.