Skip to content

Commit

Permalink
Resolve libyaml warning when loading parameters from file
Browse files Browse the repository at this point in the history
Fixes #160
  • Loading branch information
dawonn-haval committed Jul 8, 2020
1 parent 54ab32d commit 787d5a3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions launch_ros/launch_ros/utilities/to_parameters_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,19 @@ def to_parameters_list(
if isinstance(params_set_or_path, pathlib.Path):
with open(str(params_set_or_path), 'r') as f:
params_set = evaluate_parameter_dict(
context, normalize_parameter_dict(yaml.load(f))
context, normalize_parameter_dict(yaml.safe_load(f))
)
else:
params_set = params_set_or_path
if not isinstance(params_set, dict):
raise RuntimeError('invalid evaluated parameters {}'.format(repr(params_set)))
raise RuntimeError(
'invalid evaluated parameters {}'.format(repr(params_set)))
for name, value in params_set.items():
type_ = next((
type_ for type_ in rclpy.parameter.Parameter.Type if type_.check(value)
), None) # type: rclpy.parameter.Parameter.Type
if type_ is None:
raise RuntimeError('invalid parameter value {}'.format(repr(value)))
raise RuntimeError(
'invalid parameter value {}'.format(repr(value)))
parameters.append(rclpy.parameter.Parameter(name, type_, value))
return parameters

0 comments on commit 787d5a3

Please sign in to comment.