Skip to content

Commit

Permalink
Avoid creative Node argument renaming.
Browse files Browse the repository at this point in the history
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
  • Loading branch information
hidmic committed Sep 23, 2019
1 parent bce8646 commit a4be9d0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions launch_ros/launch_ros/actions/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ def parse(cls, entity: Entity, parser: Parser):
args = entity.get_attr('args', optional=True)
if args is not None:
kwargs['arguments'] = super()._parse_cmdline(args, parser)
node_name = entity.get_attr('node_name', optional=True)
if node_name is None and 'name' in kwargs:
node_name = kwargs['name']
node_name = entity.get_attr('node-name', optional=True)
if node_name is not None:
kwargs['node_name'] = node_name
kwargs['package'] = parser.parse_substitution(entity.get_attr('pkg'))
Expand Down

0 comments on commit a4be9d0

Please sign in to comment.