New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node_name warning stacklevel #138

Merged

sloretz merged 1 commit into master from sloretz/node_name_warning_stacklevel

Mar 27, 2020

Contributor

sloretz commented Mar 27, 2020

This increases the stacklevel of the node_name deprecation warning so it's easier to find the offending code.

Before:

  /home/sloretz/ws/ros2/build/launch_ros/launch_ros/actions/node.py:153: UserWarning: The parameter 'node_name' is deprecated, use 'name' instead
    warnings.warn("The parameter 'node_name' is deprecated, use 'name' instead")

With this PR

  /home/sloretz/ws/ros2/src/ros2/ros2cli/ros2node/test/test_cli.py:57: UserWarning: The parameter 'node_name' is deprecated, use 'name' instead
    Node(


          Bump node_name warning stacklevel

3c69252

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

sloretz self-assigned this

Contributor Author

sloretz commented Mar 27, 2020

CI (testing just launch_ros)

Linux
Linux-aarch64
macOS
Windows

claireyywang approved these changes

View reviewed changes

sloretz merged commit f485d3e into master

delete-merged-branch bot deleted the sloretz/node_name_warning_stacklevel branch

March 27, 2020 19:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment