Avoid using sys.argv in rclpy.init for the RosAdapters Node #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Thanks for the fix @ivanpauno, LGTM !
About deprecating old rules, AFAIK they have been already (see ros2/rcl#603)
mmm, I was still seeing some deprecation warnings ... but that PR is recent, maybe my workspace wasn't up to date. |
|
CI config:
Jobs:
|
ivanpauno
changed the title
delete-merged-branch
bot
deleted the
ivanpauno/fix-passing-argv-to-rclpy-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106 (comment).
I was thinking on a regression test, but capturing the output to check if the warning was print doesn't sound like a correct solution, as they are temporal (talking about that: @hidmic should the support of the old command line arguments be deleted for Foxy or for G-Turtle?).
Currently,
rclpydoesn't provide a way to introspect the arguments that were used to initialize a Context, so I don't see a good way of adding a regression test (without also adding that minimal enhancement inrclpy)).