Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using sys.argv in rclpy.init for the RosAdapters Node #144

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Avoid using sys.argv in rclpy.init for the RosAdapters Node #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion launch_ros/launch_ros/ros_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def __init__(
:param: argv List of global arguments for rclpy context initialization.
:param: autostart Whether to start adapter on construction or not.
"""
self.__argv = argv
# Do not use `None` here, as `rclpy.init` will use `sys.argv` in that case.
self.__argv = [] if argv is None else argv
self.__ros_context = None
self.__ros_node = None
self.__ros_executor = None
Expand Down