Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return text value to avoid exception #338

Merged

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Dec 3, 2022

Closes #337

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with full CI

@adityapande-1995
Copy link
Contributor

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@adityapande-1995
Copy link
Contributor

Windows CI round 2 : Build Status

@adityapande-1995 adityapande-1995 merged commit af784b2 into ros2:rolling Dec 7, 2022
wep21 added a commit to wep21/launch_ros that referenced this pull request Dec 8, 2022
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing numerical parameter causes exception
2 participants