fixed using wrong type of stamp #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
approved these changes
Oct 30, 2018
|
|
@ahuizxc It appears that there are some failing tests in the CI. Please update to fix these. |
I think there are something wrong about test case code, should i modify the test code ? |
|
Yes, that's totally reasonable. We expect all tests to pass (or at least no new tests to break) before merging changes. |
Already done! Thanks for your time :) |
|
|
That failure was an issue that we saw before, but should be resolved on Windows. I'm going to trigger it again to make sure it wasn't just a flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, when stamp = msg.header.stamp, it will raise errors because msg.header.stamp is builtin_interfaces.msg.Time, and it doesn't have nanoseconds attribute. So i fixed this problem :)