Switch to ament_cmake_vendor_package #24
Conversation
Signed-off-by: Scott K Logan <logans@cottsay.net>
| VCS_URL https://github.com/pybind/pybind11.git | ||
| VCS_VERSION v2.9.1 | ||
| PATCHES patches | ||
| GLOBAL_HOOK |
There was a problem hiding this comment.
Out of curiosity, why do we enable GLOBAL_HOOK for this project and not others like libyaml or spdlog?
There was a problem hiding this comment.
I added GLOBAL_HOOK where I found that there were downstream packages which were find_package-ing the vendored package without find_package-ing the vendor package first, meaning that there was a dependency on the vendored payload being globally findable outside the context of the vendor pattern.
It appears that this is one of those packages, but libyaml and spdlog are not. There is an argument that those others should use GLOBAL_HOOK even if no packages currently in ros2.repos require it, but I'd rather add it later if we find that it's necessary than continue the globally-available pattern any longer.
Part of ament/ament_cmake#429