Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use private substitution in lifecycle topics and services #260

Merged
merged 2 commits into from
Jun 17, 2018
Merged

Use private substitution in lifecycle topics and services #260

merged 2 commits into from
Jun 17, 2018

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jun 15, 2018

This is an improvement I discovered and made during my launch development.

@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Jun 15, 2018
@wjwwood wjwwood self-assigned this Jun 15, 2018
@wjwwood wjwwood requested a review from Karsten1987 June 15, 2018 22:36
@tfoote tfoote self-requested a review June 16, 2018 00:35
@tfoote
Copy link
Contributor

tfoote commented Jun 16, 2018 •
edited by wjwwood
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member Author

wjwwood commented Jun 16, 2018

Thanks!

tfoote
tfoote reviewed Jun 16, 2018
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good from reading through them. I've triggered CI and have a local workspace rebuilding to test them manually as well.

tfoote
tfoote approved these changes Jun 16, 2018
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I validated https://github.com/ros2/ros2/wiki/Managed-Nodes manually locally. Linux CI has passed. MacOS failed due to disconnect so I restarted it. It looks good to go once CI finishes.

@wjwwood wjwwood merged commit ced4947 into master Jun 17, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 17, 2018
@wjwwood wjwwood deleted the use_private_substitution_in_lifecycle_topics_and_services branch June 17, 2018 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

Assignees

@wjwwood wjwwood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjwwood @tfoote