Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rosidl dependencies #265

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Fix rosidl dependencies #265

merged 2 commits into from
Jul 5, 2018

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Jul 3, 2018

This package does not generate any message so it doesnt need to depend on the generators, instead it should link against the libraries that provide the symbols it uses (in this case rosidl_generator_c)

Connects to ros2/demos#264

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 3, 2018
@mikaelarguedas
Copy link
Member Author

CI for this at ros2/demos#264 (comment)

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 3, 2018
@mikaelarguedas mikaelarguedas self-assigned this Jul 4, 2018
@mikaelarguedas mikaelarguedas merged commit 9a9762f into master Jul 5, 2018
@mikaelarguedas mikaelarguedas deleted the remove_unused_deps branch July 5, 2018 20:01
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants