Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of uninitialized CMake var #268

Merged
merged 1 commit into from
Jul 11, 2018
Merged

remove use of uninitialized CMake var #268

merged 1 commit into from
Jul 11, 2018

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Jul 11, 2018 •
edited
Loading

When building with --warn-uninitialized the variable is being flagged so it can be safely removed.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 11, 2018
@dirk-thomas dirk-thomas self-assigned this Jul 11, 2018
mikaelarguedas
mikaelarguedas approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit 0ed0581 into master Jul 11, 2018
@dirk-thomas dirk-thomas deleted the remove_use_of_uninitialized_var branch July 11, 2018 15:38
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @mikaelarguedas