Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashing backport] MAX_STRING_SIZE increase #503

Merged
merged 1 commit into from Sep 19, 2019
Merged

[dashing backport] MAX_STRING_SIZE increase #503

merged 1 commit into from Sep 19, 2019

Conversation

zmichaels11
Copy link

@zmichaels11 zmichaels11 commented Sep 18, 2019 •
edited by tfoote

Dashing backport of #487

@hyunseok-yang @zmichaels11
Increase MAX_STRING_SIZE (#487)
fa65056 
* Increase MAX_STRING_SIZE

It's too short for string length.
It occurs the error when the string field in yaml files are too long....

Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>

* update test to match increased limit

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
@zmichaels11
Copy link
Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@tfoote tfoote changed the title Backport #487 for Dashing. [dashing backport] MAX_STRING_SIZE increase Sep 19, 2019
@dirk-thomas
Copy link
Member

The patch looks fine to me but the CI builds seem to test master not dashing?

@tfoote
Copy link
Contributor

tfoote commented Sep 19, 2019

@zmichaels11 please relaunch CI using a repos file that's branched from the dashing branch. https://github.com/ros2/ros2/blob/dashing/ros2.repos

@tfoote tfoote mentioned this pull request Sep 19, 2019
Merged
@zmichaels11
Copy link
Author

zmichaels11 commented Sep 19, 2019 •
edited

Trying again, but with dashing

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@zmichaels11
Copy link
Author

@dirk-thomas its passing now

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

Thanks for making the backport.

@dirk-thomas dirk-thomas merged commit 6aa3eb5 into ros2:dashing Sep 19, 2019
@zmichaels11 zmichaels11 deleted the zmichaels11/backport-#487 branch September 19, 2019 22:57
@tfoote tfoote added this to Released in Dashing Patch Release 4 Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas Awaiting requested review from dirk-thomas

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dashing Patch Release 4
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmichaels11 @dirk-thomas @tfoote @hyunseok-yang