Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation to rcl_lifecycle #622

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 20, 2020

Added documentation to:

  • rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h
  • rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h
  • rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 20, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde marked this pull request as ready for review April 21, 2020 13:13
@ahcorde ahcorde requested a review from Blast545 April 22, 2020 07:26
@ahcorde ahcorde added the ready Work is about to start (Kanban column) label Apr 22, 2020
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some minor suggested modifications

rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/transition_map.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/transition_map.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/transition_map.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/transition_map.h Outdated Show resolved Hide resolved
rcl_lifecycle/include/rcl_lifecycle/transition_map.h Outdated Show resolved Hide resolved
Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 24, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

relaunched Linux-aarch64 with the uncrustify fix

Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 27, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Unrelated warning

@ahcorde ahcorde merged commit e00b4b8 into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/doc/rcl_lifecycle branch April 27, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready Work is about to start (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants