Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-specification of default values in ParameterValue msg #19

Closed
dhood opened this issue Aug 22, 2017 · 2 comments
Closed

Remove double-specification of default values in ParameterValue msg #19

dhood opened this issue Aug 22, 2017 · 2 comments
Assignees

Comments

@dhood
Copy link
Member

dhood commented Aug 22, 2017

Default values were added explicitly in #18 to prevent a valgrind error of uninitialised fields during serialisation. When messages can be created as pre-initialised with default values in client libraries, revert that PR and use default-initialised messages instead (to prevent specification of the default values in multiple locations).

Depends on ros2/ros2#396
Connects to ros2/ros2#396

@mikaelarguedas
Copy link
Member

#18 Needs to be reverted once ros2/ros2#396 related PRs are merged.
@clalancette FYI, not sure if you want to "connect" them together

@clalancette
Copy link
Contributor

@mikaelarguedas Thanks for the heads up; I'll connect this up with #396 as you suggest.

@mikaelarguedas mikaelarguedas self-assigned this Nov 1, 2017
@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Nov 1, 2017
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants