Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about unused return value for set_logger_level #38

Merged
merged 1 commit into from May 15, 2020

Conversation

dirk-thomas
Copy link
Member

In combination with ros2/rcl#652.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label May 15, 2020
@dirk-thomas dirk-thomas self-assigned this May 15, 2020
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These implementations return rcl_logging_ret_t instead of rcl_ret_t? I'm confused.

@dirk-thomas
Copy link
Member Author

These implementations return rcl_logging_ret_t instead of rcl_ret_t?

Sorry, not part of this PR.

@dirk-thomas dirk-thomas merged commit ba92511 into master May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/warn-unused-set-logger-level branch May 15, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants