Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rcutils_expand_user() in rcl_logging_get_logging_directory() #59

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Use rcutils_expand_user() in rcl_logging_get_logging_directory() #59

merged 1 commit into from
Oct 20, 2020

Conversation

christophebedard
Copy link
Member

Follow-up to #53, now that rcutils_expand_user has been added (ros2/rcutils#298).

@christophebedard
Use rcutils_expand_user in rcl_logging_get_logging_directory
eb10ac9 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Copy link
Member Author

I'm guessing a new release of rcutils might need to be created for the Rpr job to pass.

@clalancette
Copy link
Contributor

I'm guessing a new release of rcutils might need to be created for the Rpr job to pass.

Agreed, I'll go ahead and do that.

@clalancette
Copy link
Contributor

New release of rcutils is done, lets see if the PR build succeeds now.

@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

clalancette
clalancette approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now that PR jobs are passing. I'll also do a CI run on it.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The 4 failures on Windows are flaky right now. So I'm going to go ahead and merge this, thanks for the change.

@clalancette clalancette merged commit 7eec954 into ros2:master Oct 20, 2020
@christophebedard christophebedard deleted the use-rcutils-expand-user branch October 20, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophebedard @clalancette