Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include what you use #71

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Include what you use #71

merged 1 commit into from
Jan 12, 2021

Conversation

ivanpauno
Copy link
Member

MAX_PATH is defined in windows.h and after ros2/rcpputils#118 is not being automatically included by rcpputils/filesystem_helper.hpp anymore.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Jan 12, 2021
@ivanpauno ivanpauno self-assigned this Jan 12, 2021
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@ivanpauno
Copy link
Member Author

CI job here: ros2/rcpputils#118 (comment)

@ivanpauno ivanpauno merged commit 870bb2a into master Jan 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/no-windows-h branch January 12, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants