Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct rosdistro build for dashing #129

Closed
JanStaschulat opened this issue Jul 15, 2021 · 0 comments · Fixed by ros/rosdistro#30231
Closed

correct rosdistro build for dashing #129

JanStaschulat opened this issue Jul 15, 2021 · 0 comments · Fixed by ros/rosdistro#30231
Assignees
@JanStaschulat

Comments

@JanStaschulat
Copy link
Contributor

JanStaschulat commented Jul 15, 2021 •
edited

update bloom release for dashing.
Problem:

  • branch foxy is used for Dashing bloom release.
  • new pull requests on Foxy trigger a build on Dashing, which is EOL.

Solution:

  • created a Dashing branch (copy from Foxy)
  • change bloom release configuration to use dashing instead of foxy branch
JanStaschulat added a commit to JanStaschulat/rosdistro that referenced this issue Jul 15, 2021
@JanStaschulat
Resolves ros2/rclc#129
9288b81 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat mentioned this issue Jul 15, 2021
Merged
JanStaschulat added a commit to JanStaschulat/rosdistro that referenced this issue Jul 15, 2021
@JanStaschulat
Resolves ros2/rclc#129 keep foxy in documentation, because validate r…
6aeef62 
…osdistro check failed https://github.com/ros/rosdistro/pull/30231/checks?check_run_id=3078627512

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat mentioned this issue Jul 16, 2021
Closed
11 tasks
ahcorde pushed a commit to ros/rosdistro that referenced this issue Jul 16, 2021
@JanStaschulat
rclc: corrected branch name for Dashing (#30231)
586ce3f 
* Resolves ros2/rclc#129

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>

* Resolves ros2/rclc#129 keep foxy in documentation, because validate rosdistro check failed https://github.com/ros/rosdistro/pull/30231/checks?check_run_id=3078627512

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat self-assigned this Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanStaschulat JanStaschulat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rclc: corrected branch name for Dashing JanStaschulat/rosdistro
1 participant
@JanStaschulat