New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ API : concept for typesupport #199
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@pablogs9 interestingly, the same build error ( |
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 13 13
Lines 1493 1493
Branches 445 445
=======================================
Hits 910 910
Misses 377 377
Partials 206 206 Continue to review full report at Codecov.
|
//const rosidl_message_type_support_t * ping_type_support = | ||
// ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, String); | ||
const rosidl_message_type_support_t ping_type_support = | ||
rclcpp::get_message_type_support_handle< std_msgs::msg::String >(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need rclcpp to build rclc examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment yes. But his is not the intention.
This was a first idea for the typesupport conversion. First, I wanted to understand, which functions are necessary to write a subscriber with callback function in C++ so that it is compatible with rclc library.The idea is to factor out the necessary rclcpp functions - so that we don't have the dependency of rclcpp.
I converted this pull request to Draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks Jan
Example with ROS 2 message type support (definition of subscription and callback function).