Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ API : concept for typesupport #199

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Sep 21, 2021

Example with ROS 2 message type support (definition of subscription and callback function).

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

@pablogs9 interestingly, the same build error (rclcpp::Time), but the build on the ROS 2 build farm finishes successfully. Only Github Action has a problem!

@codecov-commenter
Copy link

Codecov Report

Merging #199 (fc49463) into master (2c2287a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files          13       13           
  Lines        1493     1493           
  Branches      445      445           
=======================================
  Hits          910      910           
  Misses        377      377           
  Partials      206      206           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2287a...fc49463. Read the comment docs.

//const rosidl_message_type_support_t * ping_type_support =
// ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, String);
const rosidl_message_type_support_t ping_type_support =
rclcpp::get_message_type_support_handle< std_msgs::msg::String >();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need rclcpp to build rclc examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment yes. But his is not the intention.

This was a first idea for the typesupport conversion. First, I wanted to understand, which functions are necessary to write a subscriber with callback function in C++ so that it is compatible with rclc library.The idea is to factor out the necessary rclcpp functions - so that we don't have the dependency of rclcpp.

I converted this pull request to Draft.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks Jan

@JanStaschulat JanStaschulat marked this pull request as draft September 27, 2021 09:41
@JanStaschulat JanStaschulat changed the title example with typesupport C++ API : concept for typesupport Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants