Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate typedefs #249

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Remove duplicate typedefs #249

merged 1 commit into from
Feb 23, 2022

Conversation

ted-miller
Copy link
Contributor

There are three typedefs that got duplicated in executor_handle.h. It looks like a copy/paste accident.

I'm using a really old compiler, and it generates an error for the redefinition. I'm guessing it's not an error with modern compilers, but it's still nice to remove unnecessary stuff from the header.

Signed-off-by: Ted Miller <ted.miller@motoman.com>
@ted-miller
Copy link
Contributor Author

I followed these instructions to add the 'signed off by' field.

To add your Signed-off-by line to every commit in this branch:

@pablogs9
Copy link
Member

LGTM, please @JanStaschulat merge if you are ok

@pablogs9
Copy link
Member

@mergify backport foxy galactic

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2022

backport foxy galactic

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

Copy link
Contributor

@JanStaschulat JanStaschulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that there are duplicates. Thanks for your PR.

@JanStaschulat JanStaschulat merged commit 2381ec5 into ros2:master Feb 23, 2022
mergify bot pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ted Miller <ted.miller@motoman.com>
(cherry picked from commit 2381ec5)
mergify bot pushed a commit that referenced this pull request Feb 23, 2022
Signed-off-by: Ted Miller <ted.miller@motoman.com>
(cherry picked from commit 2381ec5)
@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2022

backport foxy galactic

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants