Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated documentation: build status for Rolling #266

Merged
merged 17 commits into from
Apr 1, 2022

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Mar 16, 2022

updated README.md release table: rolling releases for ubuntu jammy

…or all packages.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat self-assigned this Mar 16, 2022
@JanStaschulat JanStaschulat changed the title updated documentation: bloom release table for rolling ubuntu jammy updated documentation: build status for Rolling Mar 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #266 (8b83fee) into master (3e5e219) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   64.70%   64.58%   -0.12%     
==========================================
  Files          16       16              
  Lines        2187     2197      +10     
  Branches      647      647              
==========================================
+ Hits         1415     1419       +4     
- Misses        458      461       +3     
- Partials      314      317       +3     
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 58.59% <0.00%> (-3.83%) ⬇️
...lc_parameter/src/rclc_parameter/parameter_server.c 73.20% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5e219...8b83fee. Read the comment docs.

…emoved later.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Mar 16, 2022

@ralph-lange @pablogs9 After installation of python3.9-dev, the Github Action "CI RCLC Rolling" fails because rti_connext_dds_cmake_module misses some dependency .
ModuleNotFoundError: No module named 'pyparsing'

Any ideas?

-- Found Python3: /usr/bin/python3.9 (found version "3.9.5") found components: Interpreter
CMake Warning at cmake/rti_build_helper.cmake:380 (message):
    no CONNEXTDDS_DIR nor NDDSHOME specified
  Call Stack (most recent call first):
    cmake/rti_build_helper.cmake:554 (rti_load_connextddsdir)
    CMakeLists.txt:25 (rti_find_connextpro)
  
  
  -- Invalid CONNEXTDDS_DIR = ''
  -- RTI Connext DDS Professional: NOT FOUND
  -- Invalid CONNEXTDDS_DIR = ''
  -- Invalid RTIMEHOME = ''
  -- RTIMEHOME not found
  -- RTI Connext DDS Micro: NOT FOUND
  -- no environment hook generated
  -- Found ament_lint_auto: 0.11.4 (/opt/ros/rolling/share/ament_lint_auto/cmake)
  Traceback (most recent call last):
    File "/opt/ros/rolling/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py", line 22, in <module>
      from catkin_pkg.package import parse_package_string
    File "/usr/lib/python3/dist-packages/catkin_pkg/package.py", line 44, in <module>
      from catkin_pkg.condition import evaluate_condition
    File "/usr/lib/python3/dist-packages/catkin_pkg/condition.py", line 17, in <module>
      import pyparsing as pp
  ModuleNotFoundError: No module named 'pyparsing'
  CMake Error at /opt/ros/rolling/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:95 (message):
    execute_process(/usr/bin/python3.9
    /opt/ros/rolling/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py
    /__w/rclc/rclc/ros_ws/src/ros2/rmw_connextdds/rti_connext_dds_cmake_module/package.xml
    /__w/rclc/rclc/ros_ws/build/rti_connext_dds_cmake_module/ament_cmake_core/package.cmake)
    returned error code 1
  Call Stack (most recent call first):
    /opt/ros/rolling/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:49 (_ament_package_xml)
    /opt/ros/rolling/share/ament_lint_auto/cmake/ament_lint_auto_find_test_dependencies.cmake:31 (ament_package_xml)
    CMakeLists.txt:79 (ament_lint_auto_find_test_dependencies)
  
  
  -- Configuring incomplete, errors occurred!
  See also "/__w/rclc/rclc/ros_ws/build/rti_connext_dds_cmake_module/CMakeFiles/CMakeOutput.log".
  See also "/__w/rclc/rclc/ros_ws/build/rti_connext_dds_cmake_module/CMakeFiles/CMakeError.log".
  ---
  --- stderr: rti_connext_dds_cmake_module
  CMake Warning at cmake/rti_build_helper.cmake:380 (message):
    no CONNEXTDDS_DIR nor NDDSHOME specified
  Call Stack (most recent call first):
    cmake/rti_build_helper.cmake:554 (rti_load_connextddsdir)
    CMakeLists.txt:25 (rti_find_connextpro)
  
  
  Traceback (most recent call last):
    File "/opt/ros/rolling/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py", line 22, in <module>
      from catkin_pkg.package import parse_package_string
    File "/usr/lib/python3/dist-packages/catkin_pkg/package.py", line 44, in <module>
      from catkin_pkg.condition import evaluate_condition
    File "/usr/lib/python3/dist-packages/catkin_pkg/condition.py", line 17, in <module>
      import pyparsing as pp
  ModuleNotFoundError: No module named 'pyparsing'
  CMake Error at /opt/ros/rolling/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:95 (message):
    execute_process(/usr/bin/python3.9
    /opt/ros/rolling/share/ament_cmake_core/cmake/core/package_xml_2_cmake.py
    /__w/rclc/rclc/ros_ws/src/ros2/rmw_connextdds/rti_connext_dds_cmake_module/package.xml
    /__w/rclc/rclc/ros_ws/build/rti_connext_dds_cmake_module/ament_cmake_core/package.cmake)
    returned error code 1
  Call Stack (most recent call first):
    /opt/ros/rolling/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:49 (_ament_package_xml)
    /opt/ros/rolling/share/ament_lint_auto/cmake/ament_lint_auto_find_test_dependencies.cmake:31 (ament_package_xml)
    CMakeLists.txt:79 (ament_lint_auto_find_test_dependencies)
  
  
  ---
  Failed   <<< rti_connext_dds_cmake_module [0.87s, exited with code 1]

@JanStaschulat
Copy link
Contributor Author

created an issue regarding missing pyhton3.9 for Ubuntu rolling
osrf/infrastructure#11

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

Re-running build job on Open Robotics build farm is fine, but the Github Action CI job still fails on Rolling.

Summary: 6 packages finished [41.2s]
    1 package failed: rmw_fastrtps_shared_cpp
    1 package aborted: rcl_yaml_param_parser
    4 packages had stderr output: rmw_connextdds_common rmw_fastrtps_shared_cpp rmw_implementation_cmake rti_connext_dds_cmake_module
    10 packages not processed
Error: The process '/usr/bin/bash' failed with exit code 2

https://github.com/ros2/rclc/runs/5661073739?check_suite_focus=true

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Mar 24, 2022

Error on Open Robotics build farm due to unit test of ActionClientTest:

11:55:25 1: [----------] 7 tests from ActionClientTest
11:55:25 1: [ RUN      ] ActionClientTest.goal_accept
11:55:25 1: terminate called after throwing an instance of 'std::bad_function_call'
11:55:25 1:   what():  bad_function_call
11:55:25 1: -- run_test.py: return code -6
11:55:25 1: -- run_test.py: generate result file '/tmp/ws/test_results/rclc/rclc_test.gtest.xml' with failed test
11:55:25 1: -- run_test.py: verify result file '/tmp/ws/test_results/rclc/rclc_test.gtest.xml'
11:55:25 1/6 Test #1: rclc_test ........................***Failed   14.95 sec

https://build.ros2.org/job/Rpr__rclc__ubuntu_jammy_amd64/35/console

@JanStaschulat
Copy link
Contributor Author

@pablogs9

Github Action CI RCLC build job also fails because of similar errror:

  1: [----------] 7 tests from ActionServerTest
  1: [ RUN      ] ActionServerTest.goal_accept
  1: -- run_test.py: return code -11
  1: -- run_test.py: generate result file '/__w/rclc/rclc/ros_ws/build/rclc/test_results/rclc/rclc_test.gtest.xml' with failed test
  1: -- run_test.py: verify result file '/__w/rclc/rclc/ros_ws/build/rclc/test_results/rclc/rclc_test.gtest.xml'
  1/6 Test #1: rclc_test ........................***Failed   12.97 sec

https://github.com/ros2/rclc/runs/5674993675?check_suite_focus=true

Maybe something is different for ubuntu:jammy now regarding the ActionServer or ActionClient? Could you check?

@pablogs9
Copy link
Member

I'm going to take a look

@pablogs9
Copy link
Member

No prob found building in an up to date Rolling docker with:

 root@b69c267d2131:/ws# colcon build --cmake-args -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=Debug
...
root@b69c267d2131:/ws# ./build/rclc/rclc_test --gtest_filter=ActionClientTest.*
Note: Google Test filter = ActionClientTest.*
[==========] Running 7 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 7 tests from ActionClientTest
[ RUN      ] ActionClientTest.goal_accept
[       OK ] ActionClientTest.goal_accept (17 ms)
[ RUN      ] ActionClientTest.goal_reject
[       OK ] ActionClientTest.goal_reject (15 ms)
[ RUN      ] ActionClientTest.goal_accept_feedback_and_result
[       OK ] ActionClientTest.goal_accept_feedback_and_result (113 ms)
[ RUN      ] ActionClientTest.goal_accept_feedback_and_abort
[       OK ] ActionClientTest.goal_accept_feedback_and_abort (112 ms)
[ RUN      ] ActionClientTest.goal_accept_cancel_success
[       OK ] ActionClientTest.goal_accept_cancel_success (111 ms)
[ RUN      ] ActionClientTest.goal_accept_cancel_reject
[       OK ] ActionClientTest.goal_accept_cancel_reject (116 ms)
[ RUN      ] ActionClientTest.multi_goal_accept_feedback_and_result
[       OK ] ActionClientTest.multi_goal_accept_feedback_and_result (113 ms)
[----------] 7 tests from ActionClientTest (598 ms total)

[----------] Global test environment tear-down
[==========] 7 tests from 1 test suite ran. (598 ms total)
[  PASSED  ] 7 tests.

Do you have any idea on how to replicate locally?

@pablogs9 pablogs9 closed this Mar 24, 2022
@pablogs9 pablogs9 reopened this Mar 24, 2022
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Mar 24, 2022

@pablogs9 "Do you have any idea on how to replicate locally?" Are you using the docker image ubuntu:jammy?

@pablogs9
Copy link
Member

I have replicated the environment in a Jammy and installing Rolling like it is installed in the Github action:

root@964a49307217:/ws# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu Jammy Jellyfish (development branch)
Release:        22.04
Codename:       jammy
root@964a49307217:/ws# ./build/rclc/rclc_test --gtest_filter=*Action*
Note: Google Test filter = *Action*
[==========] Running 14 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 7 tests from ActionServerTest
[ RUN      ] ActionServerTest.goal_accept
[       OK ] ActionServerTest.goal_accept (197 ms)
[ RUN      ] ActionServerTest.goal_reject
[       OK ] ActionServerTest.goal_reject (272 ms)
[ RUN      ] ActionServerTest.goal_accept_feedback_and_result
[       OK ] ActionServerTest.goal_accept_feedback_and_result (472 ms)
[ RUN      ] ActionServerTest.goal_accept_feedback_and_abort
[       OK ] ActionServerTest.goal_accept_feedback_and_abort (305 ms)
[ RUN      ] ActionServerTest.goal_accept_cancel_success
[       OK ] ActionServerTest.goal_accept_cancel_success (394 ms)
[ RUN      ] ActionServerTest.goal_accept_cancel_reject
[       OK ] ActionServerTest.goal_accept_cancel_reject (284 ms)
[ RUN      ] ActionServerTest.multi_goal_accept_feedback_and_result
[       OK ] ActionServerTest.multi_goal_accept_feedback_and_result (462 ms)
[----------] 7 tests from ActionServerTest (2386 ms total)

[----------] 7 tests from ActionClientTest
[ RUN      ] ActionClientTest.goal_accept
[       OK ] ActionClientTest.goal_accept (162 ms)
[ RUN      ] ActionClientTest.goal_reject
[       OK ] ActionClientTest.goal_reject (149 ms)
[ RUN      ] ActionClientTest.goal_accept_feedback_and_result
[       OK ] ActionClientTest.goal_accept_feedback_and_result (250 ms)
[ RUN      ] ActionClientTest.goal_accept_feedback_and_abort
[       OK ] ActionClientTest.goal_accept_feedback_and_abort (251 ms)
[ RUN      ] ActionClientTest.goal_accept_cancel_success
[       OK ] ActionClientTest.goal_accept_cancel_success (249 ms)
[ RUN      ] ActionClientTest.goal_accept_cancel_reject
[       OK ] ActionClientTest.goal_accept_cancel_reject (252 ms)
[ RUN      ] ActionClientTest.multi_goal_accept_feedback_and_result
[       OK ] ActionClientTest.multi_goal_accept_feedback_and_result (251 ms)
[----------] 7 tests from ActionClientTest (1564 ms total)

[----------] Global test environment tear-down
[==========] 14 tests from 2 test suites ran. (3950 ms total)
[  PASSED  ] 14 tests.

@JanStaschulat
Copy link
Contributor Author

Then, I don't know

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Apr 1, 2022

We are already using the pre-released ROS 2 binaries:
https://github.com/ros-tooling/setup-ros#Use-pre-release-ROS-2-binaries-for-testing

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

@pablogs9 @ralph-lange now the CI jobs run again.

  • no errors anymore related to ActionServerTest

I removed the "dependency.repos" file. We have always built rolling with the pre-release binaries (as specified in the ci.yml: (use-ros2-testing: true)

So my explanation is that we selectivly built from source (those packages in dependency.repos) and the others from binary packages. Nothing else was changed.

@JanStaschulat JanStaschulat merged commit be20b16 into master Apr 1, 2022
@JanStaschulat JanStaschulat deleted the feature/update-release-table branch April 1, 2022 13:26
JanStaschulat added a commit that referenced this pull request Apr 1, 2022
* Fix RCLC int parameter get

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Fix test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update examples

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* updated: ubuntu:jammy ros-tooling/setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated documentation: build status for Rolling (#266)

* updated documentation: bloom release table for rolling ubuntu yammy for all packages.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* install phyhton dependendcy for ubuntu yammi transition - should be removed later.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* interactive installation

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* removed installation of python3.9

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* using docker_image: ubuntu:jammy

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* using ubuntu-20.04

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* retry

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* retry

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* update text

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* commented out unit tests ActionServerTest

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* uncrustify

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* removed dependencies.repos

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* removed vcs-repo-file-url from ci.yml

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* revert ActionServerTest

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* uncrustify

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted changes in test_action_server.cpp

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* Fix RCLC int parameter get

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Fix test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Update examples

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants