-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated documentation: build status for Rolling #266
Conversation
…or all packages. Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 64.70% 64.58% -0.12%
==========================================
Files 16 16
Lines 2187 2197 +10
Branches 647 647
==========================================
+ Hits 1415 1419 +4
- Misses 458 461 +3
- Partials 314 317 +3
Continue to review full report at Codecov.
|
…emoved later. Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@ralph-lange @pablogs9 After installation of python3.9-dev, the Github Action "CI RCLC Rolling" fails because Any ideas?
|
created an issue regarding missing pyhton3.9 for Ubuntu rolling |
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Re-running build job on Open Robotics build farm is fine, but the Github Action CI job still fails on Rolling.
https://github.com/ros2/rclc/runs/5661073739?check_suite_focus=true |
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Error on Open Robotics build farm due to unit test of ActionClientTest:
https://build.ros2.org/job/Rpr__rclc__ubuntu_jammy_amd64/35/console |
Github Action CI RCLC build job also fails because of similar errror:
https://github.com/ros2/rclc/runs/5674993675?check_suite_focus=true Maybe something is different for ubuntu:jammy now regarding the ActionServer or ActionClient? Could you check? |
I'm going to take a look |
No prob found building in an up to date Rolling docker with: root@b69c267d2131:/ws# colcon build --cmake-args -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=Debug
...
root@b69c267d2131:/ws# ./build/rclc/rclc_test --gtest_filter=ActionClientTest.*
Note: Google Test filter = ActionClientTest.*
[==========] Running 7 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 7 tests from ActionClientTest
[ RUN ] ActionClientTest.goal_accept
[ OK ] ActionClientTest.goal_accept (17 ms)
[ RUN ] ActionClientTest.goal_reject
[ OK ] ActionClientTest.goal_reject (15 ms)
[ RUN ] ActionClientTest.goal_accept_feedback_and_result
[ OK ] ActionClientTest.goal_accept_feedback_and_result (113 ms)
[ RUN ] ActionClientTest.goal_accept_feedback_and_abort
[ OK ] ActionClientTest.goal_accept_feedback_and_abort (112 ms)
[ RUN ] ActionClientTest.goal_accept_cancel_success
[ OK ] ActionClientTest.goal_accept_cancel_success (111 ms)
[ RUN ] ActionClientTest.goal_accept_cancel_reject
[ OK ] ActionClientTest.goal_accept_cancel_reject (116 ms)
[ RUN ] ActionClientTest.multi_goal_accept_feedback_and_result
[ OK ] ActionClientTest.multi_goal_accept_feedback_and_result (113 ms)
[----------] 7 tests from ActionClientTest (598 ms total)
[----------] Global test environment tear-down
[==========] 7 tests from 1 test suite ran. (598 ms total)
[ PASSED ] 7 tests. Do you have any idea on how to replicate locally? |
@pablogs9 "Do you have any idea on how to replicate locally?" Are you using the docker image |
I have replicated the environment in a Jammy and installing Rolling like it is installed in the Github action: root@964a49307217:/ws# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu Jammy Jellyfish (development branch)
Release: 22.04
Codename: jammy
root@964a49307217:/ws# ./build/rclc/rclc_test --gtest_filter=*Action*
Note: Google Test filter = *Action*
[==========] Running 14 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 7 tests from ActionServerTest
[ RUN ] ActionServerTest.goal_accept
[ OK ] ActionServerTest.goal_accept (197 ms)
[ RUN ] ActionServerTest.goal_reject
[ OK ] ActionServerTest.goal_reject (272 ms)
[ RUN ] ActionServerTest.goal_accept_feedback_and_result
[ OK ] ActionServerTest.goal_accept_feedback_and_result (472 ms)
[ RUN ] ActionServerTest.goal_accept_feedback_and_abort
[ OK ] ActionServerTest.goal_accept_feedback_and_abort (305 ms)
[ RUN ] ActionServerTest.goal_accept_cancel_success
[ OK ] ActionServerTest.goal_accept_cancel_success (394 ms)
[ RUN ] ActionServerTest.goal_accept_cancel_reject
[ OK ] ActionServerTest.goal_accept_cancel_reject (284 ms)
[ RUN ] ActionServerTest.multi_goal_accept_feedback_and_result
[ OK ] ActionServerTest.multi_goal_accept_feedback_and_result (462 ms)
[----------] 7 tests from ActionServerTest (2386 ms total)
[----------] 7 tests from ActionClientTest
[ RUN ] ActionClientTest.goal_accept
[ OK ] ActionClientTest.goal_accept (162 ms)
[ RUN ] ActionClientTest.goal_reject
[ OK ] ActionClientTest.goal_reject (149 ms)
[ RUN ] ActionClientTest.goal_accept_feedback_and_result
[ OK ] ActionClientTest.goal_accept_feedback_and_result (250 ms)
[ RUN ] ActionClientTest.goal_accept_feedback_and_abort
[ OK ] ActionClientTest.goal_accept_feedback_and_abort (251 ms)
[ RUN ] ActionClientTest.goal_accept_cancel_success
[ OK ] ActionClientTest.goal_accept_cancel_success (249 ms)
[ RUN ] ActionClientTest.goal_accept_cancel_reject
[ OK ] ActionClientTest.goal_accept_cancel_reject (252 ms)
[ RUN ] ActionClientTest.multi_goal_accept_feedback_and_result
[ OK ] ActionClientTest.multi_goal_accept_feedback_and_result (251 ms)
[----------] 7 tests from ActionClientTest (1564 ms total)
[----------] Global test environment tear-down
[==========] 14 tests from 2 test suites ran. (3950 ms total)
[ PASSED ] 14 tests. |
Then, I don't know |
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
We are already using the pre-released ROS 2 binaries: |
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@pablogs9 @ralph-lange now the CI jobs run again.
I removed the "dependency.repos" file. We have always built rolling with the pre-release binaries (as specified in the ci.yml: ( So my explanation is that we selectivly built from source (those packages in dependency.repos) and the others from binary packages. Nothing else was changed. |
* Fix RCLC int parameter get Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Fix test Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update examples Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * updated: ubuntu:jammy ros-tooling/setup-ros@0.3.0 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * updated documentation: build status for Rolling (#266) * updated documentation: bloom release table for rolling ubuntu yammy for all packages. Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * install phyhton dependendcy for ubuntu yammi transition - should be removed later. Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * interactive installation Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * removed installation of python3.9 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * using docker_image: ubuntu:jammy Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * using ubuntu-20.04 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * setup-ros@0.3.0 Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * retry Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * retry Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * update text Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * commented out unit tests ActionServerTest Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * uncrustify Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * removed dependencies.repos Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * removed vcs-repo-file-url from ci.yml Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * revert ActionServerTest Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * uncrustify Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * reverted changes in test_action_server.cpp Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com> * Fix RCLC int parameter get Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Fix test Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Update examples Signed-off-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
updated README.md release table: rolling releases for ubuntu jammy