Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclc_parameter: Fix rcl return values (backport #270) #276

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 4, 2022

This is an automatic backport of pull request #270 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
(cherry picked from commit 56ee3c1)
Copy link
Contributor

@JanStaschulat JanStaschulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor

@bjsowa @pablogs9 @Acuadros95 PR is successful on build farm Fpr__rclc__ubuntu_focal_amd64. Ignoring timeout on Github Action. Merging.

@JanStaschulat JanStaschulat merged commit e5023d7 into foxy Apr 14, 2022
@JanStaschulat JanStaschulat deleted the mergify/bp/foxy/pr-270 branch April 14, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants