Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Incompatible QoS callbacks #1048

Closed
mm318 opened this issue Apr 1, 2020 · 1 comment · Fixed by #1051
Closed

Add default Incompatible QoS callbacks #1048

mm318 opened this issue Apr 1, 2020 · 1 comment · Fixed by #1051

Comments

@mm318
Copy link
Member

mm318 commented Apr 1, 2020

Feature request

Feature description

With #924 merged in, a user is able to provide a callback for when an participant on the topic is discovered but unable to be matched due to incompatible QoS policies. This feature request is for leveraging this feature even when a user does not provide a custom callback function, by setting a default callback function that prints a warning (initially suggested at ros2/ros2#822 (comment)) on the discovery of an incompatible participant on the topic.

Implementation considerations

What should the behavior be if the underlying middleware does not support this kind of QoS event callback?

@mm318
Copy link
Member Author

mm318 commented Apr 8, 2020

Relevant pull request opened at #1051.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant