Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export component manager #1070

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Export component manager #1070

merged 2 commits into from
Apr 17, 2020

Conversation

DensoADAS
Copy link
Contributor

Exporting the component manger library and the dependency to composition interfaces is missing.

Fabian König added 2 commits April 17, 2020 09:49
Export component manager library
071fb90 
Signed-off-by: Fabian König <f.koenig@eu.denso.com>
Export composition interfaces dependency
56df717 
Signed-off-by: Fabian König <f.koenig@eu.denso.com>
Karsten1987
Karsten1987 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: (build up to test_launch_ros, test rclcpp_components, test_launch_ros)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Contributor

thanks for the contribution

@Karsten1987 Karsten1987 merged commit ee6ab95 into ros2:master Apr 17, 2020
@DensoADAS DensoADAS deleted the export_component_manager branch April 18, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DensoADAS @Karsten1987