Fix #1526.

[y-okumura-isp]

Fixes #1526.

As action_server_ depends on clock_, we declare clock_ first.
Then the order of deletion becomes action_server_, clock_.

There are still errors in the following test, but we have solved errors for test_server.

• test_client
• test_server_goal_handle

[fujitatomoya]

i think that this makes sense,

rclcpp/rclcpp_action/src/server.cpp

Lines 91 to 103 in b1ff2d5

	auto deleter = [node_base](rcl_action_server_t * ptr)
	{
	if (nullptr != ptr) {
	rcl_node_t * rcl_node = node_base->get_rcl_node_handle();
	rcl_ret_t ret = rcl_action_server_fini(ptr, rcl_node);
	if (RCL_RET_OK != ret) {
	RCLCPP_DEBUG(
	rclcpp::get_logger("rclcpp_action"),
	"failed to fini rcl_action_server_t in deleter");
	}
	delete ptr;
	}
	};

ServerBaseImpl::action_server_ requires ServerBaseImpl::clock_ during deletion.

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows

[fujitatomoya]

@ivanpauno all green, could you take a look just in case?

[fujitatomoya]

Only comments changed since last CI, i will go ahead to merge this.