Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for subscriptions on another thread #1940

Merged
merged 1 commit into from
Jun 9, 2022
Merged

wait for subscriptions on another thread #1940

merged 1 commit into from
Jun 9, 2022

Conversation

fujitatomoya
Copy link
Collaborator

related to ros2/rmw_fastrtps#568 (comment)

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

@fujitatomoya
wait for subscriptions on another thread.
5d3b1ab 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request May 23, 2022
Merged
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

CI still failing with https://ci.ros2.org/job/ci_linux-aarch64/11327/testReport/

@fujitatomoya
Copy link
Collaborator Author

CI failure can be reproducible in my environment.
According to the error https://ci.ros2.org/job/ci_linux-aarch64/11327/testReport/, using LoanedMessage from the middle-ware leads to failure for destroying publisher handle in the implementation. (in this particular case, DDS writer)

@fujitatomoya fujitatomoya changed the title wait for subscriptions on another thread. LoanedMessage test adjustment Jun 4, 2022
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

https://ci.ros2.org/job/ci_windows/17196/msbuild/ and https://ci.ros2.org/job/ci_windows/17196/testReport/ are unrelated.

@fujitatomoya
Copy link
Collaborator Author

@ivanpauno can you do another review?

ivanpauno
ivanpauno approved these changes Jun 6, 2022
View reviewed changes
rclcpp/test/rclcpp/test_publisher.cpp Outdated Show resolved Hide resolved
rclcpp/test/rclcpp/test_generic_pubsub.cpp Show resolved Hide resolved
@fujitatomoya fujitatomoya force-pushed the bugfix/wait_for_subscribers_on_another_thread branch from 4af9a7c to 5d3b1ab Compare June 8, 2022 21:12
@fujitatomoya fujitatomoya changed the title LoanedMessage test adjustment wait for subscriptions on another thread Jun 8, 2022
@fujitatomoya
Copy link
Collaborator Author

This does not depend on anything but just bug fix. (CI failure can be observed only if rmw implementation uses LoanedMessage.)

@fujitatomoya fujitatomoya merged commit b3f5703 into ros2:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fujitatomoya @ivanpauno