Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax template matching rules for std::bind and GNU C++ >= 7.1 #484

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

esteve
Copy link
Member

@esteve esteve commented May 31, 2018

Connects to #479

@esteve
Copy link
Member Author

esteve commented May 31, 2018

@dhood this should fix #479 , but unfortunately I don't have the entire workspace ready right now to build map_server or the Turtlebot demo, the test I added in test_function_traits.cpp should cover that case.

@mikaelarguedas
Copy link
Member

Thanks @esteve !

I tested this patch in a tb2 workspace on bionic and it does fix the compilation error 👍

@mikaelarguedas
Copy link
Member

CI:

  • Linux Build Status

  • Linux-aarch64 Build Status

  • macOS Build Status

  • Windows Build Status

  • TB2 demo xenial Build Status

  • TB2 demo bionic Build Status

@esteve
Copy link
Member Author

esteve commented May 31, 2018

@mikaelarguedas no worries, let me know if there's anything else that needs to be fixed/improved.

@dhood I just noticed that you had submitted #480 to highlight #479. Sorry, I hadn't seen it before submitting this PR. I believe 9d5b035#diff-36b58065fa9e8269e336f296c41cdf4cR125 should pass now 🤞

@dhood
Copy link
Member

dhood commented Jun 1, 2018

No worries, thanks for taking a look at it!

@dhood dhood merged commit 97575fd into ros2:master Jun 1, 2018
@esteve
Copy link
Member Author

esteve commented Jun 5, 2018

@dhood anytime! :-) Feel free to ping me again if there's something in function_traits that needs fixing.

@esteve esteve deleted the gtest-traits branch June 5, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants