Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of uninitialized CMake var #511

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

dirk-thomas
Copy link
Member

When building with --warn-uninitialized the variable is being flagged so it can be safely removed.

Build Status

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 10, 2018
@dirk-thomas dirk-thomas self-assigned this Jul 10, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit d36910d into master Jul 10, 2018
@dirk-thomas dirk-thomas deleted the remove_use_of_uninitialized_var branch July 10, 2018 23:51
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 10, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
…e QoS policies from topic name (ros2#511)

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants