Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax tolerance because timing affected by OS scheduling #533

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Aug 17, 2018

Should reduce flakiness of this test on OS X.

fixes #457

@dhood dhood added the in review Waiting for review (Kanban column) label Aug 17, 2018
@dhood
Copy link
Member Author

dhood commented Aug 17, 2018

repeating test_node 100 times:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood dhood merged commit e409e44 into master Aug 17, 2018
@dhood dhood removed the in review Waiting for review (Kanban column) label Aug 17, 2018
@dhood dhood deleted the fix_now_flakiness branch August 17, 2018 17:03
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
…os2#533)

* Change default value for max-cache-size to 1MB

Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test of node->now() flaky on OS X
2 participants